opam: declare conflict-class in the in-tree coq-bbv.opam - #59
Open
JasonGross wants to merge 1 commit into
Open
Conversation
The rocq-extra-dev package file declares conflict-class ["coq-bbv"], but the in-tree opam file does not. Pinning to a git URL makes opam use the in-tree file in place of the repository's, wholesale, so the declaration is silently dropped and the package can be co-installed with one that vendors it. conflict-class is symmetric-by-membership, so one-sided declarations protect nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9BGQT7XUuubV6C619DW4b
JasonGross
marked this pull request as draft
July 28, 2026 05:43
JasonGross
marked this pull request as ready for review
July 28, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same one-line fix as mit-plv/coqutil: the
coq-bbvpackage file in therocq-extra-devopam repository declaresbut the in-tree
coq-bbv.opamdoes not. When bbv isopam pinned to a gitURL, opam uses the in-tree file in place of the repository's one — wholesale,
not merged — so the declaration disappears and bbv can be co-installed with a
package that vendors it.
conflict-classis symmetric-by-membership, so a single side declaring itprotects nothing. The failure mode is a silent overwrite of shared
user-contrib/paths, surfacing much later asmakes inconsistent assumptions over library ...in an unrelated dependent.This is latent for bbv today rather than actively broken — it bites on the
first pin — but it is the same defect and the same one-field fix.
opam lintreports no new warnings (the pre-existing synopsis-capitalisation warning is
untouched).