Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nop #2034

Merged
merged 1 commit into from
Mar 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Assembly/Symbolic.v
Original file line number Diff line number Diff line change
@@ -4386,6 +4386,9 @@ Definition SymexNormalInstruction {opts : symbolic_options_computed_opt} {descr:
rsp' <- Symeval (s:=stack_addr_size) (add stack_addr_size@(rsp', PreARG ((Z.of_N s/8)%Z)));
_ <- SetOperand rsp rsp';
SetOperand dst v

| nop, [] => ret tt

| _, _ => err (error.unimplemented_instruction instr)
end
| Some prefix => err (error.unimplemented_prefix instr) end
2 changes: 2 additions & 0 deletions src/Assembly/WithBedrock/Semantics.v
Original file line number Diff line number Diff line change
@@ -369,6 +369,8 @@ Definition DenoteNormalInstruction (st : machine_state) (instr : NormalInstructi
st <- SetOperand stack_addr_size s st rsp rsp';
SetOperand sa s st dst v

| nop, [] => Some st

| ret, _ => None (* not sure what to do with this ret, maybe exlude it? *)

| adc, _