Skip to content

Prevent linking existing user if uid is different #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Feb 21, 2025

What are the relevant tickets?

Fix https://github.com/mitodl/hq/issues/6588

Description (What does it do?)

If a user is currently logged in under email address, social auth should reject an attempt to link the accounts.

How can this be tested?

@annagav annagav force-pushed the ag/prevent_more_than_one_social_auth branch from caceedc to 6bab138 Compare February 21, 2025 19:25
Copy link
Collaborator

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, will functionally test in a bit.

@rhysyngsun rhysyngsun self-assigned this Mar 3, 2025
@annagav annagav force-pushed the ag/prevent_more_than_one_social_auth branch 2 times, most recently from 3b87fee to e84020e Compare March 4, 2025 18:57
@annagav annagav requested a review from rhysyngsun March 5, 2025 16:43
Copy link
Collaborator

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annagav annagav force-pushed the ag/prevent_more_than_one_social_auth branch from adb7d8c to c4a02b2 Compare March 29, 2025 03:55
@annagav annagav force-pushed the ag/prevent_more_than_one_social_auth branch from c4a02b2 to e0c47e1 Compare March 31, 2025 13:12
@annagav annagav merged commit 547c8b9 into main Mar 31, 2025
7 checks passed
@annagav annagav deleted the ag/prevent_more_than_one_social_auth branch March 31, 2025 13:50
@odlbot odlbot mentioned this pull request Mar 31, 2025
3 tasks
annagav added a commit that referenced this pull request Apr 1, 2025
@odlbot odlbot mentioned this pull request Apr 1, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants