mitogen: Refactor Importer.ALWAYS_BLACKLIST -> ImportPolicy.unsuitables#1453
Draft
moreati wants to merge 4 commits intomitogen-hq:masterfrom
Draft
mitogen: Refactor Importer.ALWAYS_BLACKLIST -> ImportPolicy.unsuitables#1453moreati wants to merge 4 commits intomitogen-hq:masterfrom
moreati wants to merge 4 commits intomitogen-hq:masterfrom
Conversation
moreati
force-pushed
the
issue1451-unsuitables
branch
3 times, most recently
from
eb161cf to
a4a52a5
Compare
moreati
force-pushed
the
issue1451-unsuitables
branch
from
a4a52a5 to
91bf9c3
Compare
…orters These are not modules that Mitogen should block import of., the previous name Importer.ALWAYS_BLACKLIST was a misnomer. It conflated their unsuitablility for serving by Mitogen with the concept of modules that should be blocked from import. Mitogen should have no opinion about whether they're imported from a local source. It is attempting to handle their import with Mitogen that we wish to avoid. With this cStringIO (& probably other platform/version specific modules) can be included regardless.
moreati
force-pushed
the
issue1451-unsuitables
branch
from
72515d6 to
8c8aada
Compare
moreati
force-pushed
the
issue1451-unsuitables
branch
2 times, most recently
from
58fd03a to
529ef0f
Compare
moreati
force-pushed
the
issue1451-unsuitables
branch
from
529ef0f to
3780ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populating ImportPolicy.unsuitables via ModuleReponder on the controller will allow the controller to dynamically add unsuitable prefixes it is aware of.
refs #1451