fix(mixtape): load the visual-experiments SDK build - #77
Merged
Merged
Conversation
#76 added `visual_experiments: true` to mixtape's init, but mixtape still loaded `${MIXPANEL_PROXY}/lib.min.js`. That build is plain 2.83.0 and has no visual experiments code, so the SDK stored the option and ignored it (`get_config('visual_experiments')` was true, `mixpanel.experiments` was undefined). Point MIXPANEL_CUSTOM_LIB_URL at the same build the main app uses since #75: `${MIXPANEL_PROXY}/libs/mixpanel-2.83.0-ve-alpha-1.min.js`. Dor's init option stays as is. Verified locally: SDK loads from the new URL, `mixpanel.experiments` exists, the paywall flag resolves, no console errors. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #76.
Problem
#76 added
visual_experiments: trueto mixtape'smixpanel.init. Mixtape still loaded${MIXPANEL_PROXY}/lib.min.js. That build is plain2.83.0and has no visual experiments code. The SDK stored the option and ignored it:get_config('visual_experiments')→truemixpanel.experiments→undefinedFix
One line in
oneoffs/mixtape/index.html. PointMIXPANEL_CUSTOM_LIB_URLat the build the main app uses since #75:The
visual_experiments: trueoption from #76 stays as is. Mixtape already loads via the snippet and does its setup in theloadedcallback, so none of the other #75 changes apply here.Verified locally
mixpanel.experimentsexistspaywall_social_proof_v1flag resolves