-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add wasm support #167
base: main
Are you sure you want to change the base?
Conversation
could we get this merged in and patch released? thank you for putting this together! i was literally about to open the same pr as i just implemented it myself before seeing this: https://github.com/willsmanley/mixpanel-flutter |
also, for wasmgc support, could yall consider including this commit? https://github.com/mixpanel/mixpanel-flutter/pull/175/files this just adds crossorigin to the CDN which allows for wasmgc usage |
Could also add section in |
Will get back to this today |
@willsmanley this is now ready for another review |
LGTM but im not a maintainer thank you for incorporating the cross site tag! |
Is there an estimate for when this will go into master? It's currently blocking us from deploying to web. Thanks! |
Do you know how to point your pubspec version to a remote git ref? That might help unblock you while we're waiting |
You can use this to refer to a specific branch and repository
|
Tried pulling this PR and using it, but is throwing errors on initialization. The error says:
This is happening when running Mixpanel.init() and is thrown from void initialize(MethodCall call) {
Map<Object?, Object?> args = call.arguments as Map<Object?, Object?>;
String token = args['token'] as String;
Map<String, dynamic> config = args['config'];
init(token, config?.jsify() ?? {});
} Using breakpoints I have verified that config is not empty. Not sure if anyone else has run into this but is there a known workaround? |
# Conflicts: # CHANGELOG.md # pubspec.yaml
Just looked at this I can't reproduce it, can you share a minimal reproducible code? |
Fixes #133
Test
To test this PR, go to the example folder and try to build the app using Wasm: