Merged
Conversation
Member
|
I've squashed your commits and rebased on main locally, may I push my changes here? |
Contributor
Author
|
Yes, please do so |
a2f3271 to
a0fcac2
Compare
Member
|
Done. Let me know what you think. I think we just need some docs and testing and it'll be good to merge. |
Contributor
Author
|
This is very clean and looks great @pawamoy 🎉 ! where should I add the doc? create a new one called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
Fixes #23
I was initially updating the jinja templates, which after a point I realized is was no longer required
Relevant resources
The additional context is in #22 #19