Add support for environment variables #205
Open
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add environment variable support.
|
Original commit: |
|
Add me, add me ... I am a helpful feature |
|
@mkj any comment on whether there'd be any blockers to accepting this, if the merge conflict were resolved? It's currently the most popular open PR. |
|
The idea seems OK, I'd left it because there wasn't any response to my initial review comment. Looking now there are a few other issues with the patch as it currently is - Note the "most popular" thumbs ups are all from the same org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to OpenSSH, support all environment variables listed on the command line (-A).
Code written by @pts