Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow action updates and fixes #87

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ltan10
Copy link
Contributor

@ltan10 ltan10 commented Mar 13, 2025

What kind of change does this PR introduce?

  • Bugfix
  • New Feature
  • Feature Improvment
  • Refactoring
  • Documentation
  • Other, please describe: Workflow actions update and fixes

Description:

  • Extend Issues/PR stale time limit from 90 to 182 days and closure from 14 days to 28 days
  • Update actions/checkout dependency version from v2 to v4
  • Update docker ml-tooling/build-environment dependency to 0.6.18
  • Fixed setup.cfg flake8 ignore configuration format
  • Update release-pipeline workflow dependency versions
    • peterjgrainger/action-create-branch from v2.0.1 to v3
    • stefanzweifel/git-auto-comit-action from v4 to v5
  • Update and fix pr-labeler workflow
    • Update actions/labeler dependency from main branch to release v5
    • Update TimonVs/pr-labeler-action dependency from v3 to v5
    • Fixed incorrect configuration-path declaration for pr-labeler-action
    • Removed env GITHUB_TOKEN reference and replaced with repo-token
    • Added permissions to workflow config as per https://github.com/TimonVS/pr-labeler-action usage guide.

Checklist:

  • I have read the CONTRIBUTING document.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

…module" AttributeError

Caused by modules not correctly loaded into namespace from commit due to Issue ml-tooling#57.
Modules now correctly loaded into namespace.
Fixes AttributeError("'FileFinder' object has no attribute 'find_module'") (ml-tooling#69)
Prioritized "find_spec" and falls back to "find_module" from loader if find_spec not available.
Some whitespace removal.
Modify argument regex
Fix Colon use in docstring in arguments blocks now formatted correctly.
Change argument detection to last colon in line.
Added support for "Reference" as a block header.
Convert quote block to admonition blocks
Added Github admonition quote block support.
Added start line anchor to regex
Changed "```" code snippet boundary detection from startswith to regex to prevent false positives.

Rework docstring markdown render. Solves issue ml-tooling#80
Improved whitespace and newline rendering.
Accepts more native markdown syntax without garbling render.
Solves Issue ml-tooling#82

Enumerate the docstring to detect end of docstring to appropriately close literal blocks, doctest and code blocks

Update literal blocks logic and format.
Syntax is same as reStructured text
…-tooling#72)

Observed in python 3.8, constructor for dataclasses had different function signature
Bump actions/stale dependency to v9
Added close message for stale issue/pr
actions/checkout to v4
Bump actions/checkout to v4
Bump peterjgrainger/action-create-branch to v3
Bump stefanzweifel/git-auto-commit-action to v5
Moved actions/labeler dependency from `main` to `v5`.
Bump TimonVS/pr-labeler-action dependency from `v3` to `v5`.

Update pr-labeler workflow config
@ltan10
Copy link
Contributor Author

ltan10 commented Mar 13, 2025

@lukasmasuch I looked at the build workflow. I got it working to building the project and reporting failures.

Tested the build workflow locally. When i suppressed all the mypy error. Build still reported failure but everything appeared to run just fine. Some notes:

  • build warning suggesting to move away from using setup.py install
  • Code checks (style, linting, safety, ...) failed.
    • I wasn't able to identify where

pr-labeler

  • Somehow failed due to mentioning 'repo-token' not supplied. although it is referenced in the workflow

close-stale-issues could not be run locally
And i did not try release-pipeline workflow

PS. i did not realize that my previous PR that i merged into my main branch would be tagging along in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant