Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to provide a more detailed and structured 'Getting Started' guide, covering dataset preparation, training configuration, and checkpoint export. It also updates the attribution section to acknowledge CMU, the FLAME Center, and NVIDIA. The review feedback suggests several improvements for better documentation clarity and consistency, including adding trailing slashes to directory links, providing direct links to configuration files, refining the description of the export step, and ensuring the attribution to original sources remains complete.
6588867 to
6502b70
Compare
|
|
||
| ```bash | ||
| git clone https://github.com/mlc-ai/Pith-Train.git && cd Pith-Train | ||
| uv venv # skip if you already have a virtual environment |
There was a problem hiding this comment.
@MasterJH5574 Good catch. I just want to remove that in-line comment with uv venv. Fixed.
There was a problem hiding this comment.
Ah no I mean the comment was added intentionally, since when there is already an existing environment, running uv venv will reset that environment.
There was a problem hiding this comment.
Got it ; I've reverted this line to keep the comment.
36e1940 to
408126d
Compare
408126d to
cc44cb3
Compare
uv venvwould prompt the user what to do if the virtual environment exists, so we can remove that separate line of comment for "skipping". It is the uv's responsiblity.