Add Claude skills for corrrectness validation#13
Merged
MasterJH5574 merged 2 commits intomlc-ai:mainfrom Apr 4, 2026
Merged
Conversation
…unspecified to support short validation runs
There was a problem hiding this comment.
Code Review
This pull request introduces a correctness validation framework to ensure code changes do not negatively impact training metrics. It includes a new Claude skill, model-specific setup and validation scripts for DeepSeek-V2-Lite and Qwen3-30B-A3B, and a utility to compare training logs. Additionally, the training configuration was modified to allow optional checkpointing. Feedback highlights a potential issue in the worktree setup documentation and recommends using explicit error handling instead of assertions for configuration checks.
MasterJH5574
approved these changes
Apr 4, 2026
Member
MasterJH5574
left a comment
There was a problem hiding this comment.
LGTM, good to have the first skill 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick regression check for code changes — run 15 training steps on both the base and feature branch, compare loss curves, and flag if anything diverged.
What's in here
.claude/skills/correctness-validation/) that walks the agent through the full workflow: figure out which models are affected, set up data, run both branches via git worktree, and compare the logs.compare.pyparses stdout logs and checks cross-entropy loss, load-balance loss, and gradient norm step-by-step against a configurable tolerance (default 1e-3).save_intervalandsave_locationinTrainingCfgare now optional (defaultNone). Settingsave_locationwithoutsave_intervallets you load a pretrained checkpoint without ever writing one back — exactly what the validation scripts need to run a quick 15-step check without cluttering the checkpoint directory.