Skip to content

fix: Wrong onHide signature #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: Wrong onHide signature #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,9 @@ export interface DateTimePickerProps {

/**
* Called when the underlying modal finishes its' closing animation
* after Confirm was pressed.
* after Confirm or Cancel was pressed.
*/
onHide?(date: Date): void;
onHide?(didPressConfirm: boolean, currentDate?: Date): void;

/**
* Used to locate this view in end-to-end tests.
Expand Down