Skip to content

fixing segfault in ProxySHAP C++ Code#506

Merged
mmschlk merged 1 commit intomainfrom
fix_segfault_bug
Mar 23, 2026
Merged

fixing segfault in ProxySHAP C++ Code#506
mmschlk merged 1 commit intomainfrom
fix_segfault_bug

Conversation

@Advueu963
Copy link
Copy Markdown
Collaborator

Motivation and Context

Found a segfault bug in ProxySHAP letting it not scale beyond 127 features.
Two tests were added to check for the corresponding segfault bugs.

Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?

Unit tests were added.

Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • An entry has been added to CHANGELOG.md (if relevant for users).
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

Copy link
Copy Markdown
Collaborator

@hbaniecki hbaniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mmschlk mmschlk merged commit 747f1f3 into main Mar 23, 2026
14 checks passed
@mmschlk mmschlk deleted the fix_segfault_bug branch March 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants