Feature/length #45
Merged
Feature/length #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix local part max length to 64 octets (was incorrectly 63) - Use strlen instead of mb_strlen to count octets not characters - Update error messages to reference RFC 5321 and RFC erratum 1690
- Test local part at exactly 64 octets (valid) - Test local part at 65 octets (invalid - exceeds RFC 5321 limit) - Test total email length exceeding 254 octets (invalid) - Test domain label exceeding 63 characters (invalid) - All 96 tests passing (92 original + 4 new length tests)
- Add maxLocalPartLength, maxTotalLength, maxDomainLabelLength to ParseOptions - Allow overriding RFC 5321 default limits (64, 254, 63) - Update Parse.php to use configurable limits instead of hardcoded values - Add getter/setter methods for all length limits - Add 4 comprehensive tests for custom length limits - All 100 tests passing (96 + 4 new custom length tests)
- Create new LengthLimits class to group length constraints - Provides cleaner API with grouped options - Add static factory methods: createDefault() and createRelaxed() - Update ParseOptions to accept LengthLimits object - Keep backward compatibility with individual getter/setter methods - All 100 tests passing Usage: // Using LengthLimits object $limits = new LengthLimits(100, 300, 100); $options = new ParseOptions([], [','], true, $limits); // Using factory $options = new ParseOptions([], [','], true, LengthLimits::createRelaxed());
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
============================================
- Coverage 75.98% 75.55% -0.43%
- Complexity 200 217 +17
============================================
Files 2 3 +1
Lines 458 495 +37
============================================
+ Hits 348 374 +26
- Misses 110 121 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add test for custom maxTotalLength validation - Add test for LengthLimits::createRelaxed() factory method - Covers previously untested code paths - All 102 tests passing (100 original + 2 new coverage tests) - Ensures test coverage increases with new features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.