Fixed executable determination#76
Open
leonboot wants to merge 1 commit intomoay:masterfrom
Open
Conversation
Executable bit is always false due to missing directory separator between recipe path and relative filename
Author
|
Another option would be to add a |
Author
|
@moay did you get around to look at this PR yet? I believe it fixes a bug which prevents authors of recipes from adding executable scripts to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when copying files from the recipe that have the executable bit set, this bit was lost after copying. The cause was that the filename used for determining whether the executable flag was set was a concatenation of the recipe path and the relative filename. However, there was no directory separator, so the path to the file was always invalid and thus the executable flag was always set to
false.I changed the code to use the absolute path to the file instead of a concatenation of the recipe path and the relative path to the file.