un-skip tests on Windows V19H1 (1903) and up#12
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 65.09% 66.13% +1.04%
==========================================
Files 42 32 -10
Lines 2833 2705 -128
==========================================
- Hits 1844 1789 -55
+ Misses 803 737 -66
+ Partials 186 179 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current
Windows versions. These tests were failing on Windows V19H1 (1903) and up,
possibly due to changes in the kernel, and were skipped in commit
8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"
This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f.
This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;
This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f. This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f