Skip to content

un-skip tests on Windows V19H1 (1903) and up#12

Draft
thaJeztah wants to merge 1 commit intomoby:mainfrom
thaJeztah:unskip_windows
Draft

un-skip tests on Windows V19H1 (1903) and up#12
thaJeztah wants to merge 1 commit intomoby:mainfrom
thaJeztah:unskip_windows

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 28, 2025

This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;

=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
    changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]

=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
    changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"

This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f. This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.13%. Comparing base (f12e6e1) to head (40e6405).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   65.09%   66.13%   +1.04%     
==========================================
  Files          42       32      -10     
  Lines        2833     2705     -128     
==========================================
- Hits         1844     1789      -55     
+ Misses        803      737      -66     
+ Partials      186      179       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
Copy link
Copy Markdown
Member Author

=== RUN   TestChangesDirsEmpty
    changes_test.go:260: Reported changes for identical dirs: [{\dirSymlink C}]
--- FAIL: TestChangesDirsEmpty (0.06s)
=== RUN   TestChangesDirsMutated
    changes_test.go:392: unexpected change "C \\dirSymlink" "\\dirnew"
--- FAIL: TestChangesDirsMutated (0.06s)

This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current
Windows versions. These tests were failing on Windows V19H1 (1903) and up,
possibly due to changes in the kernel, and were skipped in commit
8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;

    === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
        changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]

    === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
        changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"

This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f.
This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants