manager/csi,agent/csi: narrow CSI client interfaces - #3256
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3256 +/- ##
==========================================
+ Coverage 14.73% 14.74% +0.01%
==========================================
Files 200 200
Lines 93077 93094 +17
==========================================
+ Hits 13712 13730 +18
+ Misses 78019 78015 -4
- Partials 1346 1349 +3 🚀 New features to boost your workflow:
|
thaJeztah
marked this pull request as ready for review
July 25, 2026 17:20
Member
Author
Define local interfaces containing only the CSI RPCs used by the manager and agent plugins instead of depending directly on the generated gRPC client interfaces. This avoids coupling the packages and their tests to unrelated RPCs added to the upstream CSI interfaces while retaining compile-time verification that the generated clients satisfy the local interfaces. As part of this change, unexport the client methods that were only exported to satisfy the generated CSI interfaces, and remove unused fake methods from the tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
corhere
reviewed
Jul 28, 2026
corhere
left a comment
corhere
left a comment
Collaborator
There was a problem hiding this comment.
Why not just embed the interface into the fake structs? Maintaining our own subset interfaces is a lot of ceremony just so tests fail to build rather than panic at runtime when a needed method isn't faked.
// manager/csi/fakes_test.go
type fakeIdentityClient struct {
csi.IdentityClient
caps []*csi.PluginCapability
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define local interfaces containing only the CSI RPCs used by the manager and agent plugins instead of depending directly on the generated gRPC client interfaces.
This avoids coupling the packages and their tests to unrelated RPCs added to the upstream CSI interfaces while retaining compile-time verification that the generated clients satisfy the local interfaces.
As part of this change, unexport the client methods that were only exported to satisfy the generated CSI interfaces, and remove unused fake methods from the tests.
- What I did
- How I did it
- How to test it
- Description for the changelog