Propagate CSI node accessible topology - #3270
Open
toughlex-donatas wants to merge 1 commit into
Open
Conversation
Signed-off-by: Donatas Lučiūnas <donatas@toughlex.com>
toughlex-donatas
force-pushed
the
patch-1
branch
from
July 28, 2026 21:23
902c6a6 to
781502a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate
accessible_topologyreturned by the CSINodeGetInfoRPC into SwarmKit'sNodeCSIInfo.Add a regression test covering the conversion.
Problem
makeNodeInfocurrently copies only:node_idmax_volumes_per_nodeAlthough both the CSI
NodeGetInfoResponseand SwarmKit'sNodeCSIInfocontain an accessible topology field, that topology is discarded during conversion.As a result, Swarm nodes are registered without CSI topology information. The scheduler cannot match topology-constrained cluster volumes to nodes and reports:
Reproduction
Environment:
Calling
NodeGetInfodirectly returns the expected topology:However, the Swarm node description omits it:
{ "PluginName": "csi-aws-ebs:latest", "NodeID": "i-...", "MaxVolumesPerNode": 26 }Fix
Convert the CSI topology into SwarmKit's
api.Topologywhen processing theNodeGetInfoResponse.The topology remains
nilwhen the CSI plugin does not return one.Testing
go test ./agent/csi/plugin