Skip to content

Conversation

@sudhdkso
Copy link
Contributor

#️⃣연관된 이슈

X

🔀반영 브랜치

feature/discord-hook -> develop

🔧변경 사항

  • prod 환경에서 에러에 대한 디스코드 웹훅을 추가했습니다.
  • DDD + CQRS로 패키지 전환할 수 있도록 정산 관련 패키지 및 global 관련 일부 패키지를 정리했습니다.

💬리뷰 요구사항(선택)

- 통계를 위한 정산의 정산 완료 일자 필드 추가
- 통계를 위한 테이블 추가
- 통계 디스코드 웹 훅 추가
- DDD + CQRS 패턴으로 정리
- jwt/auth관련은 이어서 정리 예정
@sudhdkso sudhdkso requested a review from choyeseol December 28, 2025 01:45
@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Important

Review skipped

Too many files!

48 files out of 198 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/discord-hook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다!

File Coverage [91.38%] 🍏
MemberExpense.java 100% 🍏
TokenInvalidException.java 100% 🍏
ImageUpdater.java 100% 🍏
ImageCreator.java 100% 🍏
CharacterNotFoundException.java 100% 🍏
InvalidUniqueKeyException.java 100% 🍏
S3SaveException.java 100% 🍏
ExpenseDeleter.java 100% 🍏
MemberValidator.java 100% 🍏
MemberExpenseDeleter.java 100% 🍏
SettlementReader.java 100% 🍏
MemberExpenseReader.java 100% 🍏
ExpenseReader.java 100% 🍏
SettlementCreator.java 100% 🍏
SettlementValidator.java 100% 🍏
SettlementUpdater.java 100% 🍏
MemberExpenseCreator.java 100% 🍏
MemberDeleter.java 100% 🍏
ExpenseUpdater.java 100% 🍏
MemberCreator.java 100% 🍏
MemberExpenseValidator.java 100% 🍏
MemberExpenseUpdater.java 100% 🍏
ExpenseCreator.java 100% 🍏
CommandExpenseService.java 100% 🍏
CommandSettlementService.java 100% 🍏
Expense.java 100% 🍏
AuthController.java 100% 🍏
CharacterController.java 100% 🍏
Character.java 100% 🍏
GroupNotAuthorException.java 100% 🍏
InvalidPasswordException.java 100% 🍏
GroupNotFoundException.java 100% 🍏
ExpenseNotFoundException.java 100% 🍏
QueryExpenseService.java 100% 🍏
QuerySettlementService.java 100% 🍏
MemberDuplicateNameException.java 100% 🍏
ManagerCannotDeleteException.java 100% 🍏
InvalidMemberException.java 100% 🍏
MemberNotFoundException.java 100% 🍏
ExpenseRole.java 100% 🍏
Member.java 98.18% 🍏
CommandMemberExpenseService.java 96.3% 🍏
AuthService.java 95.12% 🍏
MemberUpdater.java 94.59% 🍏
QueryMemberExpenseService.java 94.41% 🍏
Settlement.java 92.73% 🍏
CommandMemberService.java 89.58% 🍏
KakaoClient.java 89.22% 🍏
MemberReader.java 66.67%
QueryMemberService.java 61.54%
CharacterResponse.java 52.7%
UserNotFoundException.java 50%
TokenNotFoundException.java 0%
UserPermissionException.java 0%
ImageReader.java 0%
ExpenseRoleNotFoundException.java 0%
PaymentConcurrencyException.java 0%
InvalidExpenseParticipantsException.java 0%
Total Project Coverage 91.2% 🍏

Copy link
Contributor

@choyeseol choyeseol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@sudhdkso sudhdkso merged commit 339bb87 into develop Jan 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants