Fix update-pr workflow #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot rely on values in GITHUB_ENV that were stored earlier in the same step. Instead, directly query secretsmanager as needed. Also fixes the committer-email that used the literal `BOT_EMAIL` string rather than the variable.
markrtuttle
reviewed
Jul 30, 2024
| @@ -161,10 +159,6 @@ jobs: | |||
| with: | |||
| pattern: bottle-* | |||
|
|
|||
| - name: Set up Homebrew | |||
There was a problem hiding this comment.
Have you confirmed this action gives no added value?
There was a problem hiding this comment.
We didn't have this before, so that's why I am now removing it. I only added this in one of my many debugging attempts.
.github/workflows/release-brew.yaml
Outdated
| echo "HOMEBREW_GITHUB_API_TOKEN=$(aws secretsmanager get-secret-value --secret-id RELEASE_CI_ACCESS_TOKEN | jq -r '.SecretString')" >> $GITHUB_ENV | ||
| echo "FORK_REPO=https://[email protected]/$BOT_USER/homebrew-$(echo $TAP |cut -d / -f 2).git" >> $GITHUB_ENV | ||
| echo "GITHUB_TOKEN=$HOMEBREW_GITHUB_API_TOKEN" >> $GITHUB_ENV | ||
| echo "FORK_REPO=https://$(aws secretsmanager get-secret-value --secret-id RELEASE_CI_ACCESS_TOKEN | jq -r '.SecretString')@github.com/$BOT_USER/homebrew-$(echo $TAP |cut -d / -f 2).git" >> $GITHUB_ENV |
There was a problem hiding this comment.
Have you confirmed GITHUB_TOKEN is no longer needed?
There was a problem hiding this comment.
I don't know what it should be needed for, so I'd rather try without. We only interact with a remote service (GitHub) via $FORK_REPO.
feliperodri
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot rely on values in GITHUB_ENV that were stored earlier in the same step. Instead, directly query secretsmanager as needed.
Also fixes the committer-email that used the literal
BOT_EMAILstring rather than the variable.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.