forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 48
Implement kani::Arbitrary for Wrapping, Saturating, and Simd types #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carolynzech
wants to merge
4
commits into
model-checking:main
Choose a base branch
from
carolynzech:wrapping-saturating-derive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement kani::Arbitrary for Wrapping, Saturating, and Simd types #328
carolynzech
wants to merge
4
commits into
model-checking:main
from
carolynzech:wrapping-saturating-derive
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Apr 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes as proposed below (with an additional
#[cfg(kani)]
use crate::kani;
at the top of the files) appear to work for me.
With the changes as proposed above plus an additional --- a/library/portable-simd/crates/core_simd/src/vector.rs
+++ b/library/portable-simd/crates/core_simd/src/vector.rs
@@ -1,3 +1,5 @@
+#[cfg(kani)]
+use crate::kani;
use crate::simd::{
LaneCount, Mask, MaskElement, SupportedLaneCount, Swizzle,
cmp::SimdPartialOrd,
@@ -99,6 +101,7 @@ use crate::simd::{
// directly constructing an instance of the type (i.e. `let vector = Simd(array)`) should be
// avoided, as it will likely become illegal on `#[repr(simd)]` structs in the future. It also
// causes rustc to emit illegal LLVM IR in some cases.
+#[cfg_attr(kani, derive(kani::Arbitrary))]
#[repr(simd, packed)]
pub struct Simd<T, const N: usize>([T; N])
where we get 1039 further harnesses. |
The implementations need a stability attribute. Co-authored-by: Michael Tautschnig <[email protected]>
tautschnig
approved these changes
Apr 18, 2025
c460d6d
to
d508266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
kani::Arbitrary
for theWrapping
,Saturating
, andSimd
types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.