Skip to content

Fix api.weather.gov/points response handling in WeatherTools #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 8, 2025
Merged

Fix api.weather.gov/points response handling in WeatherTools #134

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
547ac4c
Fix WeatherTools to use /forecast
stvansolano Mar 28, 2025
0a831d0
Revert to string.Join
stvansolano Mar 28, 2025
fdc2383
Merge branch 'main' into fixes/forecast-sample
stvansolano Mar 28, 2025
8f1a123
Merge branch 'main' into fixes/forecast-sample
stvansolano Mar 29, 2025
6a511c0
Merge branch 'main' into fixes/forecast-sample
stvansolano Mar 31, 2025
c7c730b
Merge branch 'main' into fixes/forecast-sample
stvansolano Apr 3, 2025
ff74a1e
Updated code
stvansolano Apr 4, 2025
69b2a34
Merge branch 'main' into fixes/forecast-sample
stvansolano Apr 4, 2025
1ae0050
Merge branch 'main' into fixes/forecast-sample
stvansolano Apr 4, 2025
74cfe6c
Merge branch 'main' into fixes/forecast-sample
stvansolano Apr 5, 2025
e460ef0
Merge branch 'main' into fixes/forecast-sample
stvansolano Apr 8, 2025
c9a1b17
Suggestion
stvansolano Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions samples/QuickstartWeatherServer/Tools/WeatherTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ public static async Task<string> GetForecast(
[Description("Longitude of the location.")] double longitude)
{
using var jsonDocument = await client.ReadJsonDocumentAsync($"/points/{latitude},{longitude}");
var jsonElement = jsonDocument.RootElement;
var periods = jsonElement.GetProperty("properties").GetProperty("periods").EnumerateArray();
var forecastUrl = jsonDocument.RootElement.GetProperty("properties").GetProperty("forecast").GetString()
?? throw new Exception($"No forecast URL provided by {client.BaseAddress}points/{latitude},{longitude}");

using var forecastDocument = await client.ReadJsonDocumentAsync(forecastUrl);
var periods = forecastDocument.RootElement.GetProperty("properties").GetProperty("periods").EnumerateArray();

return string.Join("\n---\n", periods.Select(period => $"""
{period.GetProperty("name").GetString()}
Expand All @@ -52,4 +55,4 @@ public static async Task<string> GetForecast(
Forecast: {period.GetProperty("detailedForecast").GetString()}
"""));
}
}
}