Skip to content

Add AdditionalHeader handling to ReceiveMessageAsync #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ClosetheWorld
Copy link
Contributor

Motivation and Context

SseClientTransportOptions.AdditionalHeader doesn't work.
It makes fail calling MCP that deployed to Azure Functions (or MCP server needed custom header).

How Has This Been Tested?

I tested embed my application that have sides MCP client.
Testing server environment is Azure Functions(consumption, deployed East US 2 region)

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Before this, nothing read the AdditionalHeaders option at all.

We should do the same for the POST requests and add tests as well, but this is a good change. I'll cover the POST requests and add tests as part of #291.

@halter73 halter73 merged commit bca5d26 into modelcontextprotocol:main Apr 13, 2025
11 of 13 checks passed
@ClosetheWorld ClosetheWorld deleted the additionalheader-handling branch April 14, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants