Improve testing for StreamableHttpHandler and IdleTrackingBackgroundService #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
halter73
commented
Apr 23, 2025
•
halter73
commented
- Increase default IdleTimeout from 2 minutes to two hours
- Make MaxIdleSessionCount configurable and keep the default to 10,000.
- Remove redundant CTS from StreamableHttpHandler
- StreamableHttpServerTransport.HandlePostRequest already creates the equivalent CTS which DeleteRequest_CompletesSession_WhichCancelsLongRunningToolCalls verifies
- Better test IdleTrackingBackgroundService and delete least recently active idle session first when the MaxIdleSessionCount is exceeded.
- StreamableHttpServerTransport.HandlePostRequest already creates the equivelant CTS which DeleteRequest_CompletesSession_WhichCancelsLongRunningToolCalls verifies
PederHP
reviewed
Apr 23, 2025
PederHP
approved these changes
Apr 23, 2025
src/ModelContextProtocol.AspNetCore/HttpServerTransportOptions.cs
Outdated
Show resolved
Hide resolved
src/ModelContextProtocol.AspNetCore/IdleTrackingBackgroundService.cs
Outdated
Show resolved
Hide resolved
src/ModelContextProtocol.AspNetCore/IdleTrackingBackgroundService.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Apr 24, 2025
…oc comments - This makes sense if the consumer of the API hasn't started the transport or something - This makes less sense if the other side of the connection closed the transport which should be an IOException - Or the consumer disposed the transport which should be an ObjectDisposedException - However this PR isn't prescriptive. It's just matching the doc comments to the current behavior
- Fix flaky Cancellation_ThrowsCancellationException test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.