Skip to content

Add e2e tests #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

olaservo
Copy link
Collaborator

Motivation and Context

Opening as a draft for feedback on this general approach. There's a few configs that need to get adjusted or cleaned up here and obviously the oauth part is still mostly // TODO.

Will plan to update to include Streamable Http once we can import the latest changes from the published package.

How Has This Been Tested?

To run these tests I've been doing the following:

  1. In one terminal, run Inspector locally

  2. In another terminal, run one of the transport-specific test commands, eg:

cd client
npm run test:e2e:sse
# or
npm run test:e2e:stdio

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@@ -22,12 +22,13 @@
"cli"
],
"scripts": {
"clean": "rimraf ./node_modules ./client/node_modules ./server/node_modules ./dist ./client/dist ./server/dist ./package-lock.json && npm install",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this since I was running into some complications with needing to do this manually, I can remove it before merging.

@@ -49,21 +58,28 @@
"zod": "^3.23.8"
},
"devDependencies": {
"@modelcontextprotocol/server-everything": "2025.4.25",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these dependency updates are probably from a previous attempt on same branch - main ones to pay attention to are importing server-everything and adding Playwright to dev dependences.

@olaservo olaservo changed the title Add integration tests take 2 Add e2e tests Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants