fix: Mockito inline mocking for Java 21+#207
Closed
denniskawurek wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix: Mockito inline mocking for Java 21+#207denniskawurek wants to merge 1 commit intomodelcontextprotocol:mainfrom
denniskawurek wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Before this fix the execution of the maven surefire plugin with Java 21 logged warnings that mockito should be added as a java agent, because the self-attaching won't be supported in future java releases. In Java 24 the test just broke. This problem is solved by modifying the pom.xml of the parent and doing this changes: * Adding mockito as a java agent. * Removing the surefireArgLine from the properties. This can be added back when it's needed (for example when JaCoCo will be used). Furthermore, the pom.xml in the mcp-spring-* modules now have the byte-buddy dependency included, as the test would otherwise break when trying to mock McpSchema#CreateMessageRequest.
chemicL
added a commit
that referenced
this pull request
May 8, 2025
Before this fix the execution of the maven surefire plugin with Java 21 logged warnings that mockito should be added as a java agent, because the self-attaching won't be supported in future java releases. In Java 24 the test just broke. This problem is solved by modifying the pom.xml of the parent and doing this changes: * Adding mockito as a java agent. * Removing the surefireArgLine from the properties. This can be added back when it's needed (for example when JaCoCo will be used). Furthermore, the pom.xml in the mcp-spring-* modules now have the byte-buddy dependency included, as the test would otherwise break when trying to mock McpSchema#CreateMessageRequest. Fixes #187 Co-authored-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Member
|
Thank you @denniskawurek 👏 This has now been merged as eae3840 with a small improvement regarding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix the execution of the maven surefire plugin with Java 21 logged warnings that mockito should be added as a java agent, because the self-attaching won't be supported in future java releases.
In Java 24 the test just broke.
This problem is solved by modifying the
pom.xmlof the parent and doing this changes:surefireArgLinefrom the properties. This can be added back when it's needed (for example if JaCoCo will be used).Furthermore, the
pom.xmlin themcp-spring-*modules now have the byte-buddy dependency included, as the test would otherwise break when trying to mockMcpSchema#CreateMessageRequest.Motivation and Context
This is a fix for #187
How Has This Been Tested?
I executed
mvn clean packagewith Java 17, 21 and 24 and checked for the warning and whether the modules can be built.Types of changes
Checklist