chore: Using Mono#then
#232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: He-Pin <[email protected]>
tzolov
reviewed
May 12, 2025
| @@ -314,7 +314,7 @@ private Mono<ServerResponse> handleMessage(ServerRequest request) { | |||
| return request.bodyToMono(String.class).flatMap(body -> { | |||
| try { | |||
| McpSchema.JSONRPCMessage message = McpSchema.deserializeJsonRpcMessage(objectMapper, body); | |||
| return session.handle(message).flatMap(response -> ServerResponse.ok().build()).onErrorResume(error -> { | |||
| return session.handle(message).then(Mono.defer(() -> ServerResponse.ok().build())).onErrorResume(error -> { | |||
There was a problem hiding this comment.
Why do you need to call the Mono.defer()?
Since the ServerResponse.ok().build() returns a Mono and the execution is lazy.
Mono.defer() creates a runtime wrapper as unnecessary overhead.
There was a problem hiding this comment.
hum, yes, the defer is nuneeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be Mono#then as it's a
Mono<Void>Motivation and Context
Avoid some warning.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context