refactor: consolidate MCP client initialization logic#334
Closed
refactor: consolidate MCP client initialization logic#334
Conversation
Contributor
tzolov
commented
Jun 21, 2025
tzolov
commented
- Move session setup, completion, and error callbacks into doInitialize method
- Rename variables in McpClientSession for better clarity (sink -> responseSink/resultSink)
- Move session setup, completion, and error callbacks into doInitialize method - Rename variables in McpClientSession for better clarity (sink -> responseSink/resultSink) Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
chemicL
requested changes
Jun 24, 2025
Member
chemicL
left a comment
chemicL
left a comment
There was a problem hiding this comment.
Nice improvement, thanks. Left suggestions.
| String requestId = this.generateRequestId(); | ||
|
|
||
| return Mono.deferContextual(ctx -> Mono.<McpSchema.JSONRPCResponse>create(sink -> { | ||
| return Mono.deferContextual(ctx -> Mono.<McpSchema.JSONRPCResponse>create(responseSink -> { |
Member
There was a problem hiding this comment.
responseSink vs resultSink still feel quite similar. I have a different proposal.
Sink from Mono.create shall be called pendingResponseSink.
Sink for handle operator shall be called deliveredResponseSink.
WDYT?
| } | ||
|
|
||
| private Mono<McpSchema.InitializeResult> doInitialize(McpClientSession mcpClientSession) { | ||
| private Mono<McpSchema.InitializeResult> doInitialize(Initialization initializaiton) { |
Member
There was a problem hiding this comment.
Typo in "initializaiton" -> should be initialization.
tzolov
added a commit
that referenced
this pull request
Jun 24, 2025
- Move session setup, completion, and error callbacks into doInitialize method - Rename variables in McpClientSession for better clarity (sink -> pendingResponseSink/deliveredResponseSink) Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
Author
|
Addressed review comments, rebased and merged at be719f5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.