Skip to content

refactor: rename DummyProcess to FallbackProcess in Windows stdio #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

refactor: rename DummyProcess to FallbackProcess in Windows stdio #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mcp/client/stdio/win32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def get_windows_executable_command(command: str) -> str:
return command


class DummyProcess:
class FallbackProcess:
"""
A fallback process wrapper for Windows to handle async I/O
when using subprocess.Popen, which provides sync-only FileIO objects.
Expand Down Expand Up @@ -115,7 +115,7 @@ async def create_windows_process(
env: dict[str, str] | None = None,
errlog: TextIO | None = sys.stderr,
cwd: Path | str | None = None,
) -> DummyProcess:
) -> FallbackProcess:
"""
Creates a subprocess in a Windows-compatible way.

Expand All @@ -131,7 +131,7 @@ async def create_windows_process(
cwd (Path | str | None): Working directory for the subprocess

Returns:
DummyProcess: Async-compatible subprocess with stdin and stdout streams
FallbackProcess: Async-compatible subprocess with stdin and stdout streams
"""
try:
# Try launching with creationflags to avoid opening a new console window
Expand All @@ -145,7 +145,7 @@ async def create_windows_process(
bufsize=0, # Unbuffered output
creationflags=getattr(subprocess, "CREATE_NO_WINDOW", 0),
)
return DummyProcess(popen_obj)
return FallbackProcess(popen_obj)

except Exception:
# If creationflags failed, fallback without them
Expand All @@ -158,10 +158,10 @@ async def create_windows_process(
cwd=cwd,
bufsize=0,
)
return DummyProcess(popen_obj)
return FallbackProcess(popen_obj)


async def terminate_windows_process(process: Process | DummyProcess):
async def terminate_windows_process(process: Process | FallbackProcess):
"""
Terminate a Windows process.

Expand Down