replace inefficient use of to_jsonable_python
#545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Current approach of
json.dumps(pydantic_core.to_jsonable_python(result))
is much less efficient than serializing directly to JSON.Also instead of letting one serialization failure cause fallback to
str()
, we use pydantic'sfallback
method.How Has This Been Tested?
yes.
Breaking Changes
I would expect not.
NOTE: I did change the output from a single line JSON to
indent=2
to make the output more readable where it might be exposed to a user. Happy to revert that to compact JSON if it's never going to be read by a human.Types of changes
Checklist
I have added or updated documentation as neededAdditional context