-
Notifications
You must be signed in to change notification settings - Fork 1.1k
StreamableHttp - GET request standalone SSE #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ihrpr/streamablehttp-stateless
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
edit: one suggestion on adding a test for the GET stream actually being used for notifications
@@ -87,6 +88,9 @@ async def call_tool( | |||
if i < count - 1: # Don't wait after the last notification | |||
await anyio.sleep(interval) | |||
|
|||
# This will send a resource notificaiton though standalone SSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - a test for this would be awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a test for this in the next PR, where I have a client!
As per spec, the client MAY issue an HTTP GET to the MCP endpoint. This can be used to open an SSE stream, allowing the server to communicate to the client, without the client first sending data via HTTP POST. This PR implements establishing SSE stream on GET request.
Follow ups
Stacked on top of #554