Skip to content

relax validation #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcarleton merged 7 commits into from
Jun 9, 2025
Merged

relax validation #879

pcarleton merged 7 commits into from
Jun 9, 2025

Conversation

@dr3s
Copy link
Contributor

@dr3s dr3s commented Jun 3, 2025 •
edited
Loading

  • fixed broken tests on main due to async handling
  • Relax auth validation to permit additional responses in list fields
  • Correct token_type and normalize to align with spec

Fixes #814

Motivation and Context

The validation prevented usage with 3rd party Oauth AS. The pydantic models are both used for validating hosted Oauth endpoints and validating responses from 3rd party AS.

How Has This Been Tested?

tested the simple auth client example against a remote MCP server with a 3rd party AS

Breaking Changes

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@dr3s dr3s marked this pull request as ready for review June 3, 2025 16:28
dr3s
dr3s commented Jun 3, 2025
View reviewed changes
@dr3s dr3s requested a review from pcarleton June 9, 2025 18:08
@pcarleton pcarleton merged commit 1a9ead0 into modelcontextprotocol:main Jun 9, 2025
10 checks passed
@sakalys
Copy link

sakalys commented Jun 10, 2025

Thank you, sir

Kludex
Kludex reviewed Jun 11, 2025
View reviewed changes
tests/client/test_auth.py
Comment on lines +353 to +354
@pytest.mark.anyio
async def test_has_valid_token_no_token(self, oauth_provider):
Copy link
Member

@Kludex Kludex Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change those?

This was referenced Jun 16, 2025
Closed
Closed
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
@dr3s @saqadri
relax validation (modelcontextprotocol#879)
e27536e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kludex Kludex Kludex left review comments

@pcarleton pcarleton pcarleton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OAuthMetadata as define is too restrivtive, hence produces a ValidationError

4 participants

@dr3s @sakalys @pcarleton @Kludex