feat: enable tool access to HTTP request headers #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4t145
requested changes
May 14, 2025
| @@ -84,8 +84,8 @@ async fn post_handler( | |||
| .ok_or((StatusCode::NOT_FOUND, "session not found").into_response())?; | |||
| session.handle().clone() | |||
| }; | |||
| // inject request part | |||
| message.insert_extension(parts); | |||
| let headers_to_insert: http::HeaderMap = parts.headers.clone(); | |||
There was a problem hiding this comment.
I prefer to inject whole request part, in case of people want to get other information like request uri or other data in http::Extensions
| use rmcp::handler::server::tool::{FromToolCallContextPart, ToolCallContext}; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct ReqHeaders(pub HeaderMap); |
There was a problem hiding this comment.
I prefer to use HttpReqHeaders or HttpRequestHeaders as its ident.
|
Do other MCP server implementations allow header access? I find this a useful feature and had a hard time gaining access to the headers in FastMCP python. Had to monkey patch. |
This was referenced May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
HTTP request headers weren't available in the tool context
Related: #153
How Has This Been Tested?
With an example header extractor
Breaking Changes
No
Types of changes
Checklist
Additional context