Skip to content

Add error handling tests for InMemoryTransport #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HoberMin
Copy link

@HoberMin HoberMin commented Apr 7, 2025

This PR adds comprehensive error handling tests for the InMemoryTransport class, focusing on the onerror event handler implementation and test coverage.

Motivation and Context

The InMemoryTransport class had an onerror event handler defined but it wasn't being utilized in error scenarios. This change ensures proper error handling and notification when:

  • Attempting to send messages without an established connection
  • Sending messages after the connection is closed
  • Both client and server sides of the connection

This improves the reliability and debugging capabilities of the transport layer.

How Has This Been Tested?

  • Added new test cases in inMemory.test.ts
  • Tested both client and server error scenarios
  • Verified error handling in disconnected state
  • Verified error handling after connection closure
  • All tests pass successfully

Breaking Changes

No breaking changes. This is a non-breaking enhancement that adds error handling without modifying existing behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The changes focus on improving the robustness of the InMemoryTransport class by:

  1. Adding proper error handling in the send method
  2. Implementing comprehensive test coverage for error scenarios
  3. Ensuring both client and server sides handle errors appropriately
  4. Maintaining backward compatibility with existing code

@HoberMin HoberMin changed the title feat: Add error handling tests for InMemoryTransport Add error handling tests for InMemoryTransport Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant