Skip to content

Improve stdio test Windows compatibility and refactor command logic #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HoberMin
Copy link

@HoberMin HoberMin commented Apr 8, 2025

Description

This PR improves the Windows compatibility of stdio tests and refactors the OS-specific command logic. The main changes include:

  • Move OS-specific command logic from test file to implementation
  • Add getDefaultServerParameters function for cross-platform support
  • Use more command for Windows instead of tee
  • Clean up test code structure

Motivation and Context

The stdio tests were not properly handling Windows environments, and the OS-specific logic was mixed in the test file. This PR improves code organization and cross-platform compatibility.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested on Windows environment
  • All existing tests pass
  • Verified stdio functionality works correctly on both Windows and Unix/Linux

Checklist:

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Sorry, something went wrong.

@HoberMin HoberMin changed the title feat: Improve stdio test Windows compatibility and refactor command logic Improve stdio test Windows compatibility and refactor command logic Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant