Skip to content

Add support for non default shells #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akirilyuk
Copy link

This PR adds support for non default user shells. This fixes the Issue modelcontextprotocol/servers#64

Motivation and Context

Without this changes MacUsers using the zsh shell failed to start applications via npx because spawn failed with

spawn npx ENOENT

How Has This Been Tested?

Tested locally and after the change npx and all related servers using it worked for me.

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sorry, something went wrong.

@beaulac
Copy link
Contributor

beaulac commented Apr 9, 2025

os is a nodejs core module and does not need to be installed as a dependency: https://www.npmjs.com/package/os

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants