Skip to content

Jsonrpc refactor #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cloudkkk
Copy link

@Cloudkkk Cloudkkk commented Apr 9, 2025

Motivation and Context

This change addresses the issue of repetitive code in JSON-RPC error handling by introducing a centralized sendJSONRPCError function and standardized error constants. This refactoring follows the DRY (Don't Repeat Yourself) principle

How Has This Been Tested?

Existing unit and integration tests verify that error handling functionality remains consistent
Manual testing of various error scenarios to ensure correct HTTP status codes and JSON-RPC error formatting
Verified backward compatibility with existing client code

Breaking Changes

No breaking changes. This is an internal refactoring that doesn't affect public APIs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant