-
Notifications
You must be signed in to change notification settings - Fork 564
Streamable HTTP - resume streams on disconnect #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to look at the examples or tests in depth yet, but pointed out some things I think we need to change before getting this in.
* Maximum backoff time between reconnection attempts in milliseconds. | ||
* Default is 30000 (30 seconds). | ||
*/ | ||
maxReconnectionDelay: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably a library on npm that can do some of this out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic is minimal, can come back to this later if it's non-blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per spec servers might support resumability and redelivery.
Introducing resumability and re-delivery of events for disconnection within the same client.
StreamableHTTPReconnectionOptions
interface for custom reconnection and backoffstart-notification-stream'
tool which starts notifications for that can be used for testingFollow ups: