fix: Ensure completions capability is registered on setCompletionRequestHandler call #546
+160
−198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advertising support for
completions
in servers where acompletionRequestHandler
has been defined - meaning, when at least one resource or one prompt has been registered.Just like:
registerCapabilities
is called to addtools
support onsetToolRequestHandlers
callregisterCapabilities
is called to addresources
support onsetResourceRequestHandlers
callregisterCapabilities
is called to addprompts
support onsetPromptRequestHandlers
callthis PR calls
registerCapabilities
to turncompletions
support on wheneversetCompletionRequestHandler
is calledMotivation and Context
While implementing modelcontextprotocol/inspector#441, I found out that the only way to advertise completions support was defining it manually in Server constructor argument.
How Has This Been Tested?
I've tested this both with an application with a ResourceTemplate and a prompt with
completable
argument.Breaking Changes
None
Types of changes
Checklist
Additional context