-
Notifications
You must be signed in to change notification settings - Fork 3
[update] autorubric src #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @XieLipeng0830, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the reward modeling framework by standardizing terminology from 'principles' to 'rubrics' across all components and documentation. It also introduces a significant new 'Auto-Rubric' feature, which is a training-free system designed to automatically derive evaluation criteria from preference data. This enhancement aims to improve the clarity, efficiency, and interpretability of how model responses are assessed, providing a more robust foundation for reward model development and application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant refactoring, replacing the term "Principle" with "Rubric" across the codebase to align with the new "Auto-Rubric" feature. The changes are extensive, touching documentation, code, and tests. Overall, the refactoring is well-executed and consistent. I've identified a few minor issues where the find-and-replace was overly broad, leading to incorrect terminology in specific contexts or a broken link in the documentation. My feedback focuses on correcting these instances to improve clarity and correctness. The addition of the Auto-Rubric feature and its associated documentation is a valuable enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.