Simplify borgmatic wrapper: silent passthrough, no warning#241
Merged
Conversation
The warning was unnecessary — users calling 'borgmatic' directly are transparently routed through the wrapper to borgmatic.bin with no behaviour change. The cron detection warning in svc-cron/run already handles the case where someone puts 'borgmatic' directly in their cron schedule instead of 'borgmatic-start'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The warning added in #240 turns out to be unnecessary. Users calling
borgmaticdirectly are now transparently routed through the wrapper toborgmatic.bin— no behaviour change from their perspective.The cron detection warning in
svc-cron/runalready covers the important case (someone puttingborgmaticdirectly in their cron schedule instead ofborgmatic-start).Changes:
borgmaticwrapper: remove warning, silentexec borgmatic.bin "$@"onlyborgmatic-start: revertBORGMATIC_VIA_START=1prefix (no longer needed)svc-cron/run: revertborgmatic.bin --versionback toborgmatic --versionTest plan
docker exec Borgmatic borgmatic --versionworks silently with no warningdocker exec Borgmatic borgmatic-start --versionworks as before