Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade @rocket/cli to latest version #2634

Closed
wants to merge 1 commit into from

Conversation

jonkoops
Copy link

@jonkoops jonkoops commented Feb 3, 2024

Upgrades @rocket/cli to latest version, as previous versions depend on native modules that cannot be built on Apple Silicon, causing errors when running npm install.

Copy link

changeset-bot bot commented Feb 3, 2024

⚠️ No Changeset found

Latest commit: dd86cce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonkoops
Copy link
Author

jonkoops commented Feb 4, 2024

Closing this PR as it breaks stuff when running build:site, looks like this is not part of the CI, so it all seems green. There are too many breaking changes in the various @rocket/ packages, with too little documentation on how to resolve them for me to get this fixed.

For example, the @rocket/search is suddenly no longer exporting the rocketSearch function, no idea why. There is nothing about this in the changelog and the link to the migration guide and site are dead.

Closing this PR, as I don't think this will be an easy fix with all the migration that might be required.

@jonkoops jonkoops closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant