Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook-builder): define only necessary process.env globally #2653

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

bashmish
Copy link
Member

What I did

  1. improved security by not allowing to bundle all env vars, especially unnecessarily
  2. move env.NODE_ENV to globals defined in the preview index.html, so that rare packages that require it can use it dynamically and rollup can optimise it later as a whole when bundling for production
  3. removed prebundling of tiny-invariant as it's not needed anymore which was one of the goals of above changes

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: b133b30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/storybook-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish bashmish merged commit a9292d0 into master Feb 29, 2024
6 checks passed
@bashmish bashmish deleted the fix/storybook-builder-process-env branch February 29, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant