Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for @storybook/addon-docs #2657

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Mar 1, 2024

What I did

  1. prebundle required CommonJS modules
  2. fix tocbot exports
  3. resolve @storybook/react-dom-shim

This should fix storybook build for the users of @storybook/addon-docs which is part of @storybook/addon-essentials

Copy link

changeset-bot bot commented Mar 1, 2024

🦋 Changeset detected

Latest commit: 916da5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/storybook-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish bashmish changed the title Multiple fixed for @storybook/addon-docs Multiple fixes for @storybook/addon-docs Mar 1, 2024
@bashmish bashmish merged commit 5f2f2bd into master Mar 1, 2024
6 checks passed
@bashmish bashmish deleted the fix/storybook-builder-addon-docs branch March 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant