Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issues with the package-lock.json #2865

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Jan 22, 2025

We have the following issues with the dependencies:

npm error invalid: [email protected] /Users/***/Files/Projects/modernweb-dev/web/packages/test-runner-puppeteer/node_modules/puppeteer
npm error missing: @storybook/mdx1-csf@^0.0.1, required by @storybook/[email protected]
npm error invalid: @storybook/[email protected] /Users/***/Files/Projects/modernweb-dev/web/node_modules/@storybook/theming
npm error invalid: @storybook/[email protected] /Users/***/Files/Projects/modernweb-dev/web/node_modules/@storybook/client-logger

What I did

  1. Reinstalled all storybook packages from scratch
  2. Reinstalled all puppeteer packages from scratch

Also we see now some new NPM deprecation warnings, which gives new insights and is good.

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 796fb99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish marked this pull request as draft January 22, 2025 15:37
@bashmish bashmish force-pushed the fix/issues-with-the-lock branch from c5579cc to 833c829 Compare January 27, 2025 18:03
@bashmish bashmish marked this pull request as ready for review January 27, 2025 18:04
@bashmish bashmish force-pushed the fix/issues-with-the-lock branch from 833c829 to 796fb99 Compare January 27, 2025 18:06
@bashmish bashmish merged commit d3330b3 into master Jan 27, 2025
7 of 9 checks passed
@bashmish bashmish deleted the fix/issues-with-the-lock branch January 27, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant