Skip to content

update(intersect): refactor "forgrive" parameter to "forgive" #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

jlarsen-usgs
Copy link
Contributor

  • update forgive return value to None, None for consistency

* update forgive return value to None, None for consistency
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.5%. Comparing base (ff5624e) to head (0e7f600).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/discretization/modeltime.py 33.3% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2516   +/-   ##
========================================
  Coverage     55.5%    55.5%           
========================================
  Files          644      644           
  Lines       124157   124249   +92     
========================================
+ Hits         68922    68982   +60     
- Misses       55235    55267   +32     
Files with missing lines Coverage Δ
flopy/discretization/modeltime.py 76.9% <33.3%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlarsen-usgs jlarsen-usgs merged commit e626aca into modflowpy:develop May 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant