refactor: update usgsprograms.txt #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #236 +/- ##
=============================================
- Coverage 84.858% 83.936% -0.923%
=============================================
Files 20 20
Lines 3507 3511 +4
=============================================
- Hits 2976 2947 -29
- Misses 531 564 +33
🚀 New features to boost your workflow:
|
wpbonelli
reviewed
May 23, 2025
| @@ -900,7 +900,7 @@ def _set_cflags(target, cc="gcc", argv=True, osname=None, verbose=False): | |||
| elif target == "gridgen": | |||
| if osname in ("linux", "darwin"): | |||
| if cc.startswith("i"): | |||
| cflags += ["-GR"] | |||
| cflags += ["-frtti"] | |||
There was a problem hiding this comment.
this leaves the compile command like -fno-rtti ... -frtti but it works. need to figure out why -fno-rtti is getting in in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.