-
Notifications
You must be signed in to change notification settings - Fork 28
Git issue 040 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Git issue 040 #41
Conversation
Hi @salkinium and @chris-durand this fixes the |
When using the This might be related to #38, as there is/was definitely a problem that I simply swept under the rug here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
Hi @salkinium and @jwakely based on the review comments, I have converted this into a draft PR until I/we straighten out the math declarations more clealry. Cc: @chris-durand |
This partially reverts 5a4c53d and adds the constants needed for it to work. Fixes: modm-io#40
OK folks, the latest, greatest So @chris-durand and @salkinium in I believe this one is ready now. |
This PR fixes #40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @salkinium and @chris-durand. I think this one is good to go. Also, I could probably take a more active role in the support of this thing. So if you'd like to have that discussion, I'm all ears. There is a lot of value in this work. We could discuss the future evolution of this work any time. Cc: @jwakely |
That would be great! You've already polished this repo a lot, so I've upgraded you to write access, so you should be able to merge this PR now. |
This PR is intended to repair missing C++11 ` functions.
It addresses #40.
In my naive analysis, simply the position of a preprocessor
#if
-#else
-#endif
was actually removing C++11 math functions from the header.