Skip to content

Git issue 040 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Git issue 040 #41

wants to merge 11 commits into from

Conversation

ckormanyos
Copy link
Collaborator

This PR is intended to repair missing C++11 ` functions.

It addresses #40.

In my naive analysis, simply the position of a preprocessor #if-#else-#endif was actually removing C++11 math functions from the header.

@ckormanyos
Copy link
Collaborator Author

Hi @salkinium and @chris-durand this fixes the fpclassify omission (and also a few other C++11 mathematical functions).

@ckormanyos
Copy link
Collaborator Author

ckormanyos commented May 12, 2025

When using the avr-gcc image in CI to build the examples, I had breifly activated 64-bit double and, indeed, that linker is broken. So I walked the example back to 32-bit double.

This might be related to #38, as there is/was definitely a problem that I simply swept under the rug here.

@salkinium salkinium linked an issue May 14, 2025 that may be closed by this pull request
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@ckormanyos ckormanyos marked this pull request as draft May 14, 2025 19:43
@ckormanyos
Copy link
Collaborator Author

Hi @salkinium and @jwakely based on the review comments, I have converted this into a draft PR until I/we straighten out the math declarations more clealry.

Cc: @chris-durand

@ckormanyos
Copy link
Collaborator Author

OK folks, the latest, greatest <cmath> and improved docs is ready to go now. I've handled all of the review comments from @jwakely (thank you for these). We have closed #42 and will fix <cmath> here in this one.

So @chris-durand and @salkinium in I believe this one is ready now.

@ckormanyos ckormanyos marked this pull request as ready for review May 15, 2025 11:25
@ckormanyos
Copy link
Collaborator Author

This PR fixes #40

Copy link

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckormanyos
Copy link
Collaborator Author

Hi @salkinium and @chris-durand.

I think this one is good to go. Also, I could probably take a more active role in the support of this thing. So if you'd like to have that discussion, I'm all ears.

There is a lot of value in this work. We could discuss the future evolution of this work any time.

Cc: @jwakely

@salkinium
Copy link
Member

Also, I could probably take a more active role in the support of this thing.

That would be great! You've already polished this repo a lot, so I've upgraded you to write access, so you should be able to merge this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

<cmath> does not publish std::fpclassify()
3 participants