Added the support for vertical swipe direction.#8
Open
rFlex wants to merge 1 commit intomodocache:masterfrom
Open
Added the support for vertical swipe direction.#8rFlex wants to merge 1 commit intomodocache:masterfrom
rFlex wants to merge 1 commit intomodocache:masterfrom
Conversation
|
Hey, just wanted to say thanks! |
|
Hey thanks for your code Check it out! 👍 ❤️ |
Contributor
|
@rFlex were you able to test it on iPhone 5S, 6, 6 Plus? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I just found out your lib, thanks for the sharing, this is really well done.
I had the need for the support of the vertical swipe, so I added a "allowedSwipeDirections" property in the MDCSwipeOptions. By default it is set to MDCSwipeDirectionLeft | MDCSwipeDirectionRight. I had to change the const value of the MDCSwipeDirection in order to use the "OR" operator properly.