Skip to content

fix: neoforge mod being incorrectly detected as resource pack #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prospector merged 1 commit into from
Jan 1, 2026
Merged

fix: neoforge mod being incorrectly detected as resource pack #5013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/frontend/src/providers/version/manage-version-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ export function createManageVersionContext(

async function checkIsResourcePack(file: File): Promise<boolean> {
try {
const name = file.name.toLowerCase()
if (!name.endsWith('.zip')) return false

const zip = await JSZip.loadAsync(file)
const entries = Object.keys(zip.files).map((f) => f.toLowerCase())

Expand All @@ -226,6 +229,9 @@ export function createManageVersionContext(

async function checkIsDataPack(file: File): Promise<boolean> {
try {
const name = file.name.toLowerCase()
if (!name.endsWith('.zip')) return false

const zip = await JSZip.loadAsync(file)
const entries = Object.keys(zip.files).map((f) => f.toLowerCase())

Expand Down